Re: [Xen-devel] [PATCH 2/2] libxl: save helper: Recheck fd events

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 2/2] libxl: save helper: Recheck 
fd events"):
> On Tue, 2015-04-14 at 18:31 +0100, Ian Jackson wrote:
> > The save helper message reader does operates with the fd in blocking
> 
> s/does //?

Oops, fixed.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> I think that makes both of them, but based on 0/2 I think we are
> awaiting a Tested-by from Konrad (who wasn't CC-d I've done so now).

Thanks.  Konrad was CC'd on the 0/2, but you weren't, so I have just
bounced it to you.


Having slept on this I wonder if it might be better to always do this
recheck in the event core before making the fd callback.  The current
semantics are a bit of a gotcha.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel