Re: [Xen-devel] [PATCH 2/2] xen/arm: Make HAS_PCI compilable on ARM by adding place-holder code

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-04-13 at 13:18 +0530, Manish Jaggi wrote:
> uint8_t pci_conf_read8(
> +    uint32_t seg, uint32_t bus, uint32_t dev, uint32_t func,
> +    uint32_t reg)

Shouldn't this (and the other functions) match the prototype in
xen/pci.h, which is:
uint8_t pci_conf_read8(
    unsigned int seg, unsigned int bus, unsigned int dev, unsigned int func,
    unsigned int reg);
?

We generally try and use precisely sized types in the ARM code, but
where we interact with generic/common interfaces we should either follow
what they do or make an argument (via a preparatory patch) for changing
them.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel