Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Tian, Kevin
> Sent: Friday, April 17, 2015 6:57 AM
> > +int vmx_domain_enable_pml(struct domain *d)
> > +{
> > +    struct vcpu *v;
> > +    int rc;
> > +
> > +    ASSERT(atomic_read(&d->pause_count));
> > +
> > +    if ( vmx_domain_pml_enabled(d) )
> > +        return 0;
> > +
> > +    for_each_vcpu( d, v )
> > +        if ( (rc = vmx_vcpu_enable_pml(v)) != 0 )
> > +            goto error;
> > +
> > +    d->arch.hvm_domain.vmx.status |= VMX_DOMAIN_PML_ENABLED;
> 
> I didn't see how this domain-wise flag is useful. Or if we really
> want to go this way, you also need to clear this flag if vcpu pml
> enable is failed in vcpu hotplug phase, since the flag itself means
> all vcpus of the domain so we must keep this intention in all
> places.
> 

forget this comment. Your [08/11] did it. :-)

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel