Re: [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Apr 20, Ian Campbell wrote:

> It makes no sense to do that at init time, the whole purpose of a
> defbool is to allow the calling application to choose a value or to
> explicitly leave it as a request to for the default (which might vary
> depending on other selections).

Yes, and thats why my patch does?

 libxl_device_vfb_init(x_vfb);
+libxl_defbool_set(&x_vfb->sdl.opengl, 0);
 if (libxl_defbool_val(vfb.sdl.opengl))
   ;

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel