[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()



On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:

This:
> +     /* MTRR was used if this is non-zero */
> +     if (!dd->wc_cookie)
>               vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

And this:
> +             dd->wc_cookie = arch_phys_wc_add(pioaddr, piolen);
> +             if (dd->wc_cookie < 0)
> +                     ret = -EINVAL;

don't agree on what wc_cookie will be on error.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
              GPG KeyID: 0E572FDD


Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.