Re: [Xen-devel] [PATCH v3 3/4] sched: credit2: indent code sections to make review of patch 4/4 easier

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2015-03-25 at 23:48 -1000, Justin T. Weaver wrote:
> Functions runq_tickle and choose_cpu both have code sections that get turned
> into loops in patch 4 v3, soft affinity. Do the indenting here to make the
> patch 4 diff section easier to read. 
>
Yeah, I know what you mean, an thanks for trying making our job
easier! :-)

Still, it's rather uncommon a thing  to do (it's probably the first time
I see it), and I can't call myself a fan of it. So, I'm not sure what
others think, but me, I'd say just drop this patch, and do all the
functional and non-functional changes all at once.

Hopefully, splitting patch4 the way George suggests will make the result
easier to review anyway.

Thanks and Regards,
Dario

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel