Re: [Xen-devel] [PATCH OSSTEST RFC] Osstest/Debian.pm: Use Fqdn hostprop when collecting host keys

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST RFC] Osstest/Debian.pm: Use Fqdn 
hostprop when collecting host keys"):
> That code is:
> 
>     my $defaultfqdn = $name;
>     $defaultfqdn .= ".$c{TestHostDomain}" unless $defaultfqdn =~ m/\./;
>     $ho->{Fqdn} = get_host_property($ho,'fqdn',$defaultfqdn);
> 
> Perhaps for now I should write:
> 
>         my $defaultfqdn = $node;
>         $defaultfqdn .= ".$c{TestHostDomain}" unless $defaultfqdn =~ m/\./;
>         
>         my %props;
>         $mhostdb->get_properties($node, \%props);
>         
>         my $longname= $props{Fqdn} ? $props{Fqdn} : $defaultfqdn;
> 
> ?

Sure.  Except you probably mean

          my $longname= $props{Fqdn} // $defaultfqdn;

> Mainly becuase here in preseed_create we lack a $ho object I think.

Indeed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel