Re: [Xen-devel] [PATCH v2 1/2] Introduce configure option --with-system-qemu-traditional

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Apr 16, 2015 at 12:24:58PM +0100, Stefano Stabellini wrote:
> Introduce a configure option to disable the in-tree qemu-traditional
> build and use an externally provided qemu-dm binary. The option is very
> similar to the existing --with-system-qemu-xen.
                          ^^^^^
                          --with-system-qemu

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  INSTALL                |    3 +++
>  tools/configure.ac     |   16 ++++++++++++++++
>  tools/libxl/libxl_dm.c |   11 ++++++++++-
>  3 files changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/INSTALL b/INSTALL
> index a0f2e7b..3c7c56f 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -107,6 +107,9 @@ qemu-traditional.
>    --enable-qemu-traditional
>    --enable-rombios
>  
> +Use the given qemu-traditional binary instead of compiling a private copy.
> +  --with-system-qemu-traditional=PATH
> +
>  The libxl toolstack uses the upstream qemu per default. A private copy
>  will be built. If desired this private copy can be configured with
>  additional options passed to its configure script.
> diff --git a/tools/configure.ac b/tools/configure.ac
> index d31c2f3..9bad253 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -169,6 +169,22 @@ AC_DEFINE([HAVE_ROMBIOS], [1], [ROMBIOS enabled])
>  ])
>  AC_SUBST(rombios)
>  
> +AC_ARG_WITH([system-qemu-traditional],
> +    AS_HELP_STRING([--with-system-qemu-traditional@<:@=PATH@:>@],
> +       [Use system supplied qemu-traditional PATH or qemu-dm
> +       (taken from $PATH) as qemu-traditional device model instead of
> +       building and installing our own version]),[
> +    case $withval in
> +    yes) qemu_traditional=n; qemu_traditional_path=qemu-dm ;;
> +    no)  qemu_traditional=y; qemu_traditional_path= ;;
> +    *)   qemu_traditional=n; qemu_traditional_path=$withval ;;
> +    esac
> +],[])

Shouldn't this have something similar to qemu_xen case -- test
architecture to determine whether to build it or not.

And how does this option interact with --enable-qemu-traditional?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel