Re: [Xen-devel] [libvirt] [PATCH] libxl: support soundhw for hvm domains

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 04.05.2015 22:35, Jim Fehlig wrote:
> The xend driver and the parsing/formating code in src/xenconfig
> have long supported soundhw.  Add support in the libxl driver too.
> 
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> 
> This patch continues the tradition of silently ignoring unsupported
> config in the libxl driver.  But it is an improvement; post-patch
> only sound devices after the first are ignored :-).
> 
>  src/libxl/libxl_conf.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 2a09190..fccada5 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -678,6 +678,19 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
>                  libxl_defbool_set(&b_info->u.hvm.hpet, 1);
>              }
>          }
> +
> +        if (def->nsounds > 0) {
> +            /*
> +             * Use first sound device.  man xl.cfg(5) describes soundhw as
> +             * a single device.  From the man page: soundhw=DEVICE
> +             */
> +            virDomainSoundDefPtr snd = def->sounds[0];
> +
> +            if (VIR_STRDUP(b_info->u.hvm.soundhw,
> +                           virDomainSoundModelTypeToString(snd->model)) < 0)
> +                return -1;
> +        }
> +
>          for (i = 0; i < def->os.nBootDevs; i++) {
>              switch (def->os.bootDevs[i]) {
>                  case VIR_DOMAIN_BOOT_FLOPPY:
> 

ACK

Michal

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel