[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

>>> On 05.05.15 at 16:09, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
>> Sent: 05 May 2015 11:54
>> On 05/05/15 11:25, Paul Durrant wrote:
>> > @@ -5657,21 +5664,11 @@ static int hvm_allow_set_param(struct domain
>> *d,
>> >      case HVM_PARAM_IDENT_PT:
>> >      case HVM_PARAM_DM_DOMAIN:
>> >      case HVM_PARAM_ACPI_S_STATE:
>> I think you can safely elide the above cases into default.  All that
>> matters in this case is that none of the whitelisted parameters need to
>> pause the domain.
> I think you and Jan differ there, unless I misunderstood Jan.

Right, I specifically asked for these to be retained. It's just that
the comment preceding them is not visible from the patch
context, so that purpose isn't obvious here.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.