Re: [Xen-devel] [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 07/04/15 12:24, Chen Baozi wrote:
> We have already had the boot pagetable when reaching the point
> of early_printk fixmap setup. Thus there is no longer necessary
> to calculate physical address of xen_fixmap.
> 
> Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>

This patch has been fully ack and Chen agreed that you fix the typoes.
Can you commit it?

Cheers,

> ---
>  xen/arch/arm/arm64/head.S | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 75b7ee1..9ed9a93 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -519,8 +519,7 @@ paging:
>          cbnz  x22, 1f
>  
>          /* Add UART to the fixmap table */
> -        ldr   x1, =xen_fixmap
> -        add   x1, x1, x20            /* x1 := paddr (xen_fixmap) */
> +        ldr   x1, =xen_fixmap        /* x1 := vaddr (xen_fixmap) */
>          lsr   x2, x23, #THIRD_SHIFT
>          lsl   x2, x2, #THIRD_SHIFT   /* 4K aligned paddr of UART */
>          mov   x3, #PT_DEV_L3
> 


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel