[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST Nested PATCH v9 4/9] Edit some APIs in TestSupport.pm for nested test

On Sat, 2015-05-02 at 14:28 +0800, longtao.pang wrote:
> From: "longtao.pang" <longtaox.pang@xxxxxxxxx>
> 1. If vif model is defined for guest, use it in guest's configuration
> 2. In L2 installation context, its host (L1) shall not have a static IP
> but stored in runvar in L1 installation before; use this stored runvar
> IP.
> Signed-off-by: longtao.pang <longtaox.pang@xxxxxxxxx>

The code looks good, thanks. I have some minor formatting/wording nits.

> @@ -1513,14 +1517,15 @@ sub prepareguest ($$$$$$) {
>      store_runvar("${gn}_hostname", $hostname);
>      store_runvar("${gn}_tcpcheckport", $tcpcheckport);
>      store_runvar("${gn}_boot_timeout", $boot_timeout);

Blank line here please.

> +    my $gho= selectguest($gn, $ho);
> +    store_runvar("${gn}_domname", $gho->{Name});

A blank line here please.

> +    #if we have defined guest specific disksize, override it

Space after "#" please and ideally "If" not "if".

I would say "use it" rather than "override it".

> +    $mb = guest_var($gho,'disksize',$mb);

And no blank line here. (i.e. assignment of $mb nestles against the
following if and not the preceding store_runvar)

With that stuff fixed: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.