Re: [Xen-devel] [PATCH v4 1/3] x86/hvm: give HVMOP_set_param and HVMOP_get_param their own functions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.05.15 at 17:47, <paul.durrant@xxxxxxxxxx> wrote:
> The level of switch nesting in those ops is getting unreadable. Giving
> them their own functions does introduce some code duplication in the
> the pre-op checks but the overall result is easier to follow.
> 
> This patch is code movement (including style fixes). There is no
> functional change.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/hvm.c |  556 
> +++++++++++++++++++++++++-----------------------
>  1 file changed, 294 insertions(+), 262 deletions(-)

This doesn't apply to current staging (conflicts with at least
0a246b41cab40e3409c361c1ef6c1fcfaba5fd1f).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel