Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

[Antti Kantee <pooka@xxxxxx>]

On 06/05/15 11:03, Stefano Stabellini wrote:
> On Wed, 6 May 2015, Ian Jackson wrote:
> > Stefano Stabellini writes ("Re: [PATCH] OSSTEST: introduce a raisin build 
> > test"):
> > > That's fine as there is no hidden git cloning with raisin. All the trees
> > > are specified explicitly in the config file.
> > Is this a fundamental design principle ?
> >
> > The rump kernel build system uses git submodules, which are (very
> > annoying and) a kind of hidden git cloning, and it also has a
> > [psuedo-submodule a bit like xen.git wrt qemu et al.
> Oh dear lord.
>
> I am keeping not having hidden git cloning as a fundamental design
> principle and goal of the project. I haven't tried to integrated rump
> kernels into raisin yet, but as I told you IRL, I have been thinking of
> writing the build system in a way that the git cloning is done by
> raisin, even for rump kernels.
Well, these days it pulls the submodules in if they're not already 
present.  If you pull them in manually before running the build script, 
no hidden cloning happens.  Given that you want to pull them in manually 
anyway, I don't see a problem.
It's actually more of a historic remnant from times when checking out 
the necessary sources was a non-trivial operation involving separate 
user/kernel repositories and copying/patching sources all around.  I 
think it was fixed over a year ago.
I guess I could remove the "git submodule update" detection/execution 
from the build script entirely.  It's sort of illogical that you don't 
have to execute it after you clone initially but realistically speaking 
have to execute it after every pull -- makes us look like drug dealers.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel