[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH 2/3] cs-bisection-step: Report conflict if basis pass/fail are wrong

It can happen that the (for example) supposed basis pass (originally
only tested on another host) failed (when reproduced, or for some
other reason).  When that happens do not attempt to get it to pass;
instead, treat it the same way we would if we had actually got
conflicting results at that revision.

(Conversely, do not attempt to get a basis fail if the basis fail has
already passed on the selected host.  This is, as it happens,
impossible in a bisection triggered by sg-report-flight with the
current invocation arrangements - but cs-bisection-step should
handle it correctly.)

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
 cs-bisection-step |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/cs-bisection-step b/cs-bisection-step
index 14f3638..4200c16 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -771,7 +771,11 @@ sub need_repro ($$$) {
     my $fl= $n->{Flights} || [];
     foreach my $f (sort { $a->{Flight} <=> $b->{Flight} } @$fl) {
         next unless $f->{Flight} > $repro_lastflight;
-        next unless $f->{Result} eq $st;
+       if ($f->{Result} ne $st) {
+           return report_conflict($n, $what, 'Unexpected test results')
+               if $f->{Result} =~ m/^(?:pass|fail)$/;
+           next;
+       }
         print STDERR " ".
             ($repro_count ? "Repro" : "Result").
             " found: flight $f->{Flight} ($st), for $what\n";

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.