[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 3/3] xen: block access to IO port 0xcf9

>>> On 07.05.15 at 16:54, <roger.pau@xxxxxxxxxx> wrote:
> This port is used by PM1a and should not be accessed directly by Dom0.

I don't think this is unconditionally PM1a - that should be read out
of the FADT if at all. I also don't think port CF9 universally serves
as the port to do reboots. I.e. I don't think this should be done

> This
> also premits trapping 2 and 4 byte accesses to 0xcf8, which need to be
> handled by the hypervisor.

Only 4-byte ones need to be handled in the hypervisor, and you're
not adding any code forcing 2-byte ones to be allowed through. I.e.

> Also, since admin_io_okay is now a wrapper around ioports_access_permitted
> remove it.

... this should not be the final result afaict.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.