Re: [Xen-devel] [PATCH v4 1/4] xen: introduce a helper to allocate non-contiguous memory

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.05.15 at 16:29, <roger.pau@xxxxxxxxxx> wrote:
> The allocator uses independent calls to alloc_heap_pages in order to get the
> desired amount of memory and then maps all the independent physical
> addresses into a contiguous virtual address space.
> 
> In order to keep track of this regions a red-black tree is used.

I don't think this is needed (and makes the code needlessly large) -
reading the MFNs out of the page table entries during vfree()
should be quite fine.

Having named vfree() you may already guess that I'd also prefer
these to be called vmalloc()/vfree(), the more that I can't see why
they're being restricted to the Xen heap (rather than using
anonymous domheap allocations).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel