Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, May 07, Ian Campbell wrote:

> On Thu, 2015-05-07 at 10:10 +0200, Olaf Hering wrote:
> > On Thu, May 07, Wei Liu wrote:
> > 
> > > On Wed, May 06, 2015 at 07:08:44AM +0000, Olaf Hering wrote:
> > > > The current base directory /var/xen for domU dumps will be patched to
> > > > /var/lib/xen by most distros. Provide a configure option to avoid
> > > > patching the source.
> > 
> > 
> > > > If the option is not specified the default remains /var/xen/dump.
> > > You have not patched docs. I think it still references /var/xen/dump.
> > > I discovered this when I read the manpage of xl.cfg.
> > 
> > The default does not change. Last time I looked the docs refer to both
> > /var/xen/dump and /var/lib/xen/dump. Do you want me to update the
> > example in xl.cfg?
> 
> Does anyone actually use the non-FHS compliant current default
> of /var/xen/dump? Should we consider switching it to something more
> standard? Perhaps having done so making it configurable wouldn't be
> useful any more (although I'd be happy with it being so if desired).

Changing the default would work as well I think. Right now the path is
hardcoded. Should I adjust the patch to honour --localstatedir= or leave
the hardcoded path in the source?

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel