Re: [Xen-devel] [PATCH v4 4/4] xen: rework paging_log_dirty_op to work with hvm guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.15 at 10:28, <roger.pau@xxxxxxxxxx> wrote:
> El 07/05/15 a les 17.48, Jan Beulich ha escrit:
>>>>> On 07.05.15 at 16:29, <roger.pau@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/mm/paging.c
>>> +++ b/xen/arch/x86/mm/paging.c
>>> @@ -408,6 +408,51 @@ int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn)
>>>      return rv;
>>>  }
>>>  
>>> +static inline void *map_dirty_bitmap(XEN_GUEST_HANDLE_64(uint8) 
> dirty_bitmap,
>>> +                                     unsigned long pages,
>>> +                                     struct page_info **page)
>>> +{
>>> +    uint32_t pfec = PFEC_page_present | PFEC_write_access;
>>> +    unsigned long gfn;
>>> +    p2m_type_t p2mt;
>>> +
>>> +    gfn = paging_gva_to_gfn(current,
>>> +                            (paddr_t)(dirty_bitmap.p + (pages >> 3)),
>> 
>> Why paddr_t?
> 
> Without it I get:
> 
> paging.c:421:29: error: passing argument 2 of 'paging_gva_to_gfn' makes
> integer from pointer without a cast [-Werror]

I didn't object to the cast, but to the type used in it: This is a virtual
(guest) address, and the respective function parameter has type
"unsigned long".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel