Re: [Xen-devel] [PATCH v2 12/19] xen: arm: Annotate the handlers for HSTR_EL2.T15

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 08/05/15 11:17, Ian Campbell wrote:
> On Sat, 2015-04-25 at 22:48 +0500, Julien Grall wrote:
>> Hi Ian,
>>
>> On 17/04/2015 19:01, Ian Campbell wrote:
>>> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>> ---
>>> v2: s/Tx/T15/
>>> ---
>>>   xen/arch/arm/traps.c |   10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>>> index a2bae51..86b5655 100644
>>> --- a/xen/arch/arm/traps.c
>>> +++ b/xen/arch/arm/traps.c
>>> @@ -1720,6 +1720,11 @@ static void do_cp15_32(struct cpu_user_regs *regs,
>>>        * ARMv7 (DDI 0406C.b): B1.14.12
>>>        * ARMv8 (DDI 0487A.d): N/A
>>>        *
>>> +     * HSTR_EL2.T15
>>> +     *
>>> +     * ARMv7 (DDI 0406C.b): B1.14.14
>>> +     * ARMv8 (DDI 0487A.d): D1-1507 Table D1-55
>>> +     *
>>>        * And all other unknown registers.
>>>        */
>>>       default:
>>> @@ -1758,6 +1763,11 @@ static void do_cp15_64(struct cpu_user_regs *regs,
>>>        * ARMv7 (DDI 0406C.b): B1.14.12
>>>        * ARMv8 (DDI 0487A.d): N/A
>>>        *
>>> +     * HSTR_EL2.Tx
>>
>> Should not this Tx switch to T15 too?
> 
> It should and apparently I've already changed it in my tree for v3, not
> sure when I did that!

With that change:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel