Re: [Xen-devel] [PATCH 2/3] tools/libxc: Properly quote macro parameters

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-05-08 at 13:54 +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> ---
>  tools/libxc/include/xenctrl.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index 6994c51..fc880e1 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -270,7 +270,7 @@ struct xc_hypercall_buffer {
>   * transparently converted to the hypercall buffer as necessary.
>   */
>  #define DECLARE_HYPERCALL_BUFFER(_type, _name)                 \
> -    _type *_name = NULL;                                       \
> +    _type *(_name) = NULL;                                     \
>      xc_hypercall_buffer_t XC__HYPERCALL_BUFFER_NAME(_name) = { \
>          .hbuf = NULL,                                          \
>          .param_shadow = NULL,                                  \
> @@ -288,10 +288,10 @@ struct xc_hypercall_buffer {
>   * required.
>   */
>  #define DECLARE_HYPERCALL_BUFFER_SHADOW(_type, _name, _hbuf)   \
> -    _type *_name = _hbuf->hbuf;                                \
> +    _type *(_name) = (_hbuf)->hbuf;                            \

This seems to be the only one which matters in practice, but it's good
manners, so:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel