[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/libxc: Fix missing break from c/s b49a7517

Hi Andrew,

On 08/05/2015 21:59, Andrew Cooper wrote:
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CC: Wei Liu <wei.liu2@xxxxxxxxxx>
CC: Julien Grall <julien.grall@xxxxxxxxxx>
  tools/libxc/xc_domain.c |    1 +
  1 file changed, 1 insertion(+)

diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index 273e1fd..a7079a1 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1978,6 +1978,7 @@ static int xc_domain_unbind_pt_irq_int(
      case PT_IRQ_TYPE_SPI:
          bind->u.spi.spi = spi;
+        break;

Sorry, I haven't spot this one because I didn't exercise this code path.

I did the same mistake in xc_domain_bint_pt_irq_int which I fixed during testing.

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.