[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

Get it, thanks

On Mon, 2015-05-11 at 09:00 +0100, Jan Beulich wrote:
> >>> On 11.05.15 at 08:50, <huaitong.han@xxxxxxxxx> wrote:
> > On Fri, 2015-05-08 at 11:11 +0100, Jan Beulich wrote:
> >> >>> On 08.05.15 at 11:40, <huaitong.han@xxxxxxxxx> wrote:
> >> > All comments has been addressed, just changelog is written partly.
> >> 
> >> Certainly not. There are still hard tabs in the patch, and there was
> >> still a pointless initializer that I had pointed out before. I didn't look
> >> further.
> >> 
> > Yes,there are still hard tabs and pointless initializers to be modified.
> > Sorry for my mistakes. But which tabs should be used when I modify the
> > file like  "xen/arch/x86/cpu/mwait-idle.c" that all use hard tabs
> > instead of soft tabs? the source code in the files inside directory
> > "xen/arch/x86/cpu/" all use hard tabs.
> As said in ./CODING_STYLE exceptions to Xen style are being
> made for certain source files originally imported from elsewhere
> (Linux most commonly). Style should be consistent within a single
> file, i.e. retaining hard tabs there is okay (and really mandated),
> but adding hard tabs to files not already using such as their
> general means for indentation is not acceptable.
> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.