Re: [Xen-devel] [PATCH v6 1/4] xen: introduce a helper to allocate non-contiguous memory

[Tim Deegan <tim@xxxxxxx>]

At 16:25 +0200 on 11 May (1431361525), Roger Pau Monne wrote:
> The allocator uses independent calls to alloc_domheap_pages in order to get
> the desired amount of memory and then maps all the independent physical
> addresses into a contiguous virtual address space.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Tested-by: Julien Grall <julien.grall@xxxxxxxxxx> (ARM)
[...]
> +void *vzalloc(size_t size)
> +{
> +    void *p = vmalloc(size);
> +
> +    return p ? memset(p, 0, size) : p;
> +}

Should this be using clear_page()?  Our plain memset() is not
optimized for SSE &c.

Apart from that, this patch looks very nice indeed.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel