Re: [Xen-devel] [PATCH] xen: blkif.h: document linux xen-block multi-page ring implementation

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

El 12/05/15 a les 12.58, Bob Liu ha escrit:
> After commit 1b1586eeeb8c ("xenbus_client: Extend interface to
> support multi-page ring"), Linux xenbus driver can support multi-page ring.
> 
> Based on this interface, we got some impressive improvements by using 
> multi-page
> ring in xen-block driver. If using 64 pages as the ring, the IOPS increased
> about 15 times for the throughput testing.
> 
> The Linux implementation reuses two 'DEPRECATED' nodes('max-ring-pages' and
> 'num-ring-pages), so that nothing would be broken.
> Also removed the power of 2 limit and updated the default/max value 
> accordingly.
>
> Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>

This looks fine IMHO, the only caveat I see is that you are revamping an
old feature so we need to be careful that the implementation that's
merged on Linux is compatible with the previous implementation.

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel