[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/3] xentrace: Implement cpu mask range parsing of human values (-c).

. snip..
> Right.  Well I think all that is unnecessarily hard to understand,
> primarily because it's organized in a confusing way.

Looking at your implementation it is certainly easier (your way).

> Rather than try to nitpick you into doing it the way that seems more
> sensible to me, I've rewritten the patch a bit below.  This time I've
> actually done some basic testing with it.  What do you think?

I like it! Only one minor comment which is style related:
.. snip..
> +        /* Process until we find a range terminator */
> +        for(c=*s++; !is_terminator(c); c=*s++)

This is missing spaces.

I've committed it in (with the update) - since you are the maintainer
of xentrace.c and it has your SoB on it I figured you would be OK with
it :-)

If I errnously did it - please revert it and accept my apologies!

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.