Re: [Xen-devel] [PATCH v2 05/41] acpi : add helper function for mapping memory

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 18/05/15 15:01, Jan Beulich wrote:
>>>> On 18.05.15 at 15:26, <julien.grall@xxxxxxxxxx> wrote:
>> On 17/05/15 21:03, Parth Dixit wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/arm/acpi/lib.c
>>> @@ -0,0 +1,8 @@
>>> +#include <xen/acpi.h>
>>> +#include <asm/mm.h>
>>> +
>>> +void __iomem *
>>> +acpi_os_map_iomem(acpi_physical_address phys, acpi_size size)
>>> +{
>>> +    return __va(phys);
>>> +}
>>
>> I would have prefer two distinct patch: one for the refactoring of
>> acpi_os_map_memory and the other for implementing the ARM part
>> explaining why only using __va.
> 
> +1
> 
>> Although, given that acpi_os_map_memory only call acpi_os_map_iomem. I
>> would move acpi_os_map_memory per-architecture. FWIW, it's what Linux does.
> 
> In which Linux version did you see this to be the case? Certainly
> not 4.1-rc or anything recent... What I'm trying to get at is that
> we should please be very careful with deviating from the ACPI CA
> derived naming as well as with what is to live in os.c.

Sorry, I had in mind an older version of the ACPI series for Linux. I
forgot to check what was really done.

Although, acpi_os_map_iomem is also part of the ACPI CA. Would a
function arch_acpi_os_map_memory suit for you?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel