Re: [Xen-devel] [PATCHv6 1/3] xen: use ticket locks for spin locks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.05.15 at 17:33, <david.vrabel@xxxxxxxxxx> wrote:
> On 18/05/15 11:16, Jan Beulich wrote:
>>>>> On 14.05.15 at 13:21, <david.vrabel@xxxxxxxxxx> wrote:
>>>  void _spin_lock(spinlock_t *lock)
>>>  {
>>> +    spinlock_tickets_t tickets = { .tail = 1, };
>> 
>> This breaks the build on gcc 4.3.x (due to tail being a member of an
>> unnamed structure member of a union).
> 
> I don't have a gcc that old to hand but isn't the error here that .tail
> is part of the structure that isn't the first member of a union?

No, the error is "unknown field 'tail' specified in initializer", and ...

> Does this fix your gcc 4.3 build?

... hence this doesn't help. Iirc you just can't have initializers for
unnamed fields or their descendants.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel