Re: [Xen-devel] [PATCH v7 01/14] x86: add socket_to_cpumask

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.05.15 at 08:12, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> On Mon, May 18, 2015 at 02:21:40PM +0100, Jan Beulich wrote:
>> >>> On 08.05.15 at 10:56, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
>> > @@ -112,6 +115,8 @@ static int __devinit MP_processor_info_x(struct 
>> > mpc_config_processor *m,
>> >  {
>> >    int ver, apicid, cpu = 0;
>> >    
>> > +  total_cpus++;
>> > +
>> >    if (!(m->mpc_cpuflag & CPU_ENABLED)) {
>> >            if (!hotplug)
>> >                    ++disabled_cpus;
>> 
>> Is there a reason you can't use disabled_cpus and avoid adding yet
>> another variable?
> 
> The problem is not with disabled_cpus but with num_processors, which
> does not keep the original detected cpus in current code.
> Hence 'total_cpus = disabled_cpus + num_processors' may not be correct
> in some cases.

Please be more specific about when this is a problem (I do note that
I'm aware that the equation will not always hold, but during my
inspection while reviewing your change I didn't see that this would
ever become problematic).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel