Re: [Xen-devel] [PATCH V3 3/6] libxl: add pvusb API

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Sun, Apr 19, 2015 at 4:50 AM, Chunyan Liu <cyliu@xxxxxxxx> wrote:
> +int libxl_device_usb_getinfo(libxl_ctx *ctx, char *busid, libxl_usbinfo 
> *usbinfo)
> +{

Sorry, missed something.  This function is wrong.  It gives you
information about a *host* USB device; but should properly give you
information about a *guest* USB device.  The
libxl_device_disk_getinfo() counterpart, for example, takes a domid
and a virtual device (from within a libxl_disk structure) and returns
information about that virtual device.

Hrm... which makes me wonder whether we should use <ctrl,port> as a
unique "handle" for usb devices in the interface, or have a separate
devid for the devices themselves.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel