Re: [Xen-devel] [PATCH 1/4] x86: move syscall trampolines off the stack

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.05.15 at 18:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 18/05/15 13:46, Jan Beulich wrote:
>> +unsigned long alloc_stub_page(unsigned int cpu, unsigned long *mfn)
>> +{
>> +    unsigned long stub_va;
>> +    struct page_info *pg;
>> +
>> +    if ( *mfn )
>> +        pg = mfn_to_page(*mfn);
>> +    else
>> +    {
>> +        nodeid_t node = cpu_to_node(cpu);
>> +        unsigned int memflags = node != NUMA_NO_NODE ? MEMF_node(node) : 0;
>> +
>> +        pg = alloc_domheap_page(NULL, memflags);
>> +        if ( !pg )
>> +            return 0;
>> +
>> +        unmap_domain_page(memset(__map_domain_page(pg), 0xcc, PAGE_SIZE));
> 
> Seems like memset_page(pg, int val) might be a nice piece of cleanup.

Except for this one (which, if at all, should be a follow-up patch) I'll
see to address all of your comments for v2.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel