Re: [Xen-devel] [PATCH] xen/pci: correct comment of pci_device_detect()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.05.15 at 08:53, <tiejun.chen@xxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -905,7 +905,7 @@ out:
>  }
>  
>  /*
> - * detect pci device, return 0 if it exists, or return 0
> + * detect pci device, return 1 if it exists, or return 0
>   */
>  int __init pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func)

The comment is pretty pointless, and could go away altogether if
the function's return type was switched to bool_t. Care to do such
an alternative patch (including replacing some of the callers using
== 0 on the result to use ! instead)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel