Re: [Xen-devel] [PATCH v7 1/2] xen/pvh: use a custom IO bitmap for PVH hardware domains

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

El 20/05/15 a les 14.07, Jan Beulich ha escrit:
>>>> On 20.05.15 at 14:03, <roger.pau@xxxxxxxxxx> wrote:
>> El 20/05/15 a les 13.46, Jan Beulich ha escrit:
>>>>>> On 20.05.15 at 12:11, <roger.pau@xxxxxxxxxx> wrote:
>>>> --- a/xen/common/domain.c
>>>> +++ b/xen/common/domain.c
>>>> @@ -42,6 +42,7 @@
>>>>  #include <xsm/xsm.h>
>>>>  #include <xen/trace.h>
>>>>  #include <xen/tmem.h>
>>>> +#include <asm/setup.h>
>>>
>>> This caused the ARM build to fail. Instead of once again reverting I
>>> applied the trivial fix eab0647587 without asking for permission by
>>> you ARM maintainers - I hope that's okay in a case like this.
>>
>> I'm sorry but I'm not sure what's wrong with this chunk, and AFAICT you
>> seem to have applied it unmodified. The code added in
>> xen/common/domain.c is protected with #ifdef CONFIG_X86 and ARM has a
>> setup.h header.
> 
> Right, but I suppose you then also looked at my fixup patch, which
> I think explains what was wrong?

Yes, sorry for that, I've understood that you modified the patch in
order to prevent ARM breakage, not that you pushed another on top.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel