Re: [Xen-devel] [PATCH 3/4] x86: move I/O emulation stubs off the stack

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.05.15 at 19:48, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 18/05/15 13:47, Jan Beulich wrote:
>> @@ -2212,7 +2215,7 @@ static int emulate_privileged_op(struct 
>>      io_emul_stub[15] = 0xc3;
>>  
>>      /* Handy function-typed pointer to the stub. */
>> -    io_emul = (void *)io_emul_stub;
>> +    io_emul = (void *)(this_cpu(stubs.addr) + STUB_BUF_SIZE / 2);
> 
> As an unrelated observation during review, the two gpr switch functions
> should probably gain some knowledge of TRAP_regs_partial

You mean adding a respective assertion? This code shouldn't
otherwise need to know of that flag, as execution must not make
it here with a partial frame.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel