[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST v2] grub: remove patch to disable submenu from 20_linux_xen overlay



Ian Campbell writes ("Re: [PATCH OSSTEST v2] grub: remove patch to disable 
submenu from 20_linux_xen overlay"):
> --- /home/ianc/tmp/x/etc/grub.d/20_linux_xen  2013-07-03 04:39:20.000000000 
> +0100
> +++ overlay/etc/grub.d/20_linux_xen   2015-04-21 11:09:57.777812773 +0100

This looks good to me, apart from my comments on IRC as follows:

16:24 <Diziet> So the new diff seems to duplicate the if ${recovery}
               but [grub] upstream don't care about that ?
16:25 <Diziet> ISTM better would be if ${recovery}; then
               title="${title} (recovery..." but the gettext would
               need lifting out and urgh.

In any case, with my osstest hat on:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.