[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 01/41] arm/acpi: Build numa for x86 only



>>> On 20.05.15 at 17:21, <julien.grall@xxxxxxxxxx> wrote:
> On 20/05/15 16:07, Jan Beulich wrote:
>>>>> On 17.05.15 at 22:03, <parth.dixit@xxxxxxxxxx> wrote:
>>> From: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
>>>
>>> Numa is currently not supported for arm in xen.
>> 
>> This doesn't represent a valid reason for the code to be disabled,
>> the more that ARM will want to support NUMA sooner or later. A
>> valid reason would be if you'd have to introduce _a lot_ of code on
>> the ARM side in order to make this build - if that's the case, please
>> say so in the description, as from an architectural pov the absence
>> of the respective ACPI tables should be no issue at all.
> 
> The acpi/numa.c is calling a lot of arch specific function implemented
> in (arch/x86/srat.c). The code in acpi/numa.c is very x86 related (such
> as x2apic).
> 
> I think disable the compilation is preferable for now given that there
> is no board for testing the changes.

Or, as said in reply to patch 2, stubbing out the missing pieces in
ARM code. As said there - let's not make more spaghetti of common
code than it already is.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.