Re: [Xen-devel] [PATCH V3 4/6] xl: add pvusb commands

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, May 20, 2015 at 3:23 PM, George Dunlap
<George.Dunlap@xxxxxxxxxxxxx> wrote:
> On Sun, Apr 19, 2015 at 4:50 AM, Chunyan Liu <cyliu@xxxxxxxx> wrote:
>> Add pvusb commands: usb-ctrl-attach, usb-ctrl-detach, usb-list,
>> usb-attach and usb-detach.
>>
>> To attach a usb device to guest through pvusb, one could follow
>> following example:
>>
>>  #xl usb-ctrl-attach test_vm version=1 num_ports=8
>>
>>  #xl usb-list test_vm
>>  will show the usb controllers and port usage under the domain.
>>
>>  #xl usb-attach test_vm 1.6
>>  will find the first usable controller:port, and attach usb
>>  device whose bus address is 1.6 (busnum is 1, devnum is 6)
>>  to it. One could also specify which <controller> and which <port>.
>>
>>  #xl usb-detach test_vm 1.6
>>
>>  #xl usb-ctrl-detach test_vm dev_id
>>  will destroy the controller with specified dev_id. Dev_id
>>  can be traced in usb-list info.
>>
>> Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>
>> Signed-off-by: Simon Cao <caobosimon@xxxxxxxxx>
>
> Thanks, Chunyan.  The interface looks good to me, and a skim through
> the code doesn't turn up any obvious problems.  Someone more familiar
> with the libxl coding conventions will have to give it a stricter
> review.

Actually, sorry to take this back.  I looked at what I wrote in v2 of
the series, and I think what I suggested there was better. :-)

I pointed out that most devices -- disk, vif, pci, &c -- take the same
thing in their command-line arguments as you put in the config file.
They have parse_disk_config(), parse_vif_config(), and
xlu_parse_bdf(), each of which are called from both
parse_config_data() and the respective add commands.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel