[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST Nested PATCH v10 0/9] Introduction of netsted HVM test job

> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> Sent: Wednesday, May 20, 2015 11:39 PM
> To: Pang, LongtaoX
> Cc: xen-devel@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; wei.liu2@xxxxxxxxxx; 
> Hu,
> Robert
> Subject: Re: [OSSTEST Nested PATCH v10 0/9] Introduction of netsted HVM test 
> job
> On Wed, 2015-05-13 at 11:36 +0800, longtao.pang wrote:
> >       parsing grub which has 'submenu' primitive
> >       Changes to support '/boot' leading paths of kernel, xen, in grub
> >       Refactor installation of overlays for guest used
> >       Edit some APIs in TestSupport.pm for nested test
> >       Move the codes about memory size setting into prep()
> I've pushed the patches up to here into the osstest pretest branch from
> where it will be tested before becoming the production version of
> osstest.
> The next patch had a couple of comments which is why I stopped here.
> Also it is useful to let refactoring type stuff go through in a flight
> of its own.
> I made a couple of mods as I applied:
> In the first patch I adjusted an "if(stuff){" into "if (stuff) {"
> In the fourth patch I had to resolve a conflict with the newly added
> ${viftype} code. Since I was there I also made ${vifmodel} a prefixing
> thing like ${viftype} is for consistency.
I have git clone osstest source from 
checkout ' nestedhvm-v10-pretest' branch. Is it a typo in 
'Osstest/TestSupport.pm' or not?
vif         = [ '${viftype}${vidmodel}mac=$gho->{Ether}' ]
I think it should be:
vif         = [ '${viftype}${vifmodel}mac=$gho->{Ether}' ]

> I also included my "grub: remove patch to disable submenu from
> 20_linux_xen overlay" patch since it shouldn't be needed after your
> first change.
> I've pushed the resulting branch to:
>         git://xenbits.xen.org/people/ianc/osstest.git
>         nestedhvm-v10-pretest
> since you can't see it otherwise. If the tests don't pass for some
> reason we may need to rewind and try again, in which case you'll want to
> start with those versions.
> Test reports for osstest's own gate only go to Ian and myself, I'll copy
> the list and you as necessary, otherwise keep an eye on
> http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary for your stuff
> showing up in master in a day or two.
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.