Re: [Xen-devel] [PATCH v2] tools: add configure --with-dumpdir=DIR option

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, May 21, Ian Campbell wrote:

> On Mon, 2015-05-11 at 15:33 +0000, Olaf Hering wrote:
> [...]
> > +AC_ARG_WITH([xen-dumpdir],
> > +    AS_HELP_STRING([--with-xen-dumpdir=DIR],
> > +    [Path to directory for domU crash dumps. [/var/lib/xen/dump]]),
> 
> Should this say $localstatedir/lib/xen/dump as below?

This is the help output, the line below is a variable assignment.
I think its ok as it is. Perhaps /var can be replaced with LOCALSTATEDIR
to make it clearer.

configure --help suggests that --localestatedir is PREFIX/var, but we
force it to be /var. Too bad that can not be changed because it comes
from generic code, I think.

Olaf

> Other than that:
>         Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>         
> If you say so I can make that tweak as I apply.
> 
> > +    [xen_dumpdir_path=$withval],
> > +    [xen_dumpdir_path=$localstatedir/lib/xen/dump])
> > +
> >  if test "$libexecdir" = '${exec_prefix}/libexec' ; then
> >      case "$host_os" in
> >           *netbsd*) ;;
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel