Re: [Xen-devel] [PATCH v2 1/4] x86: move syscall trampolines off the stack

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.05.15 at 10:25, <JBeulich@xxxxxxxx> wrote:
>>>> On 21.05.15 at 13:48, <JBeulich@xxxxxxxx> wrote:
>>>>> On 21.05.15 at 13:08, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> It might be wise to have a BUILD_BUG_ON() which confirms that
>>> STUBS_PER_PAGE is a power of two, which is a requirement given the way
>>> it is used.
>> 
>> Good idea.
> 
> Sadly this can't be a BUILD_BUG_ON(), as STUBS_PER_PAGE isn't a
> compile time constant (due to the use of max()). I made it an
> ASSERT() for the time being.

Or actually no, since the other two would need to become ASSERT()s
too, I'll rather open code the max() instead.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel