Re: [Xen-devel] [PATCH v6 05/10] xsm: add XENMEM_soft_reset support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.05.15 at 16:58, <dgdegra@xxxxxxxxxxxxx> wrote:
> On 05/22/2015 05:40 AM, Jan Beulich wrote:
>>>>> On 13.05.15 at 11:49, <vkuznets@xxxxxxxxxx> wrote:
>>> --- a/xen/include/xsm/dummy.h
>>> +++ b/xen/include/xsm/dummy.h
>>> @@ -193,6 +193,13 @@ static XSM_INLINE int 
> xsm_memory_exchange(XSM_DEFAULT_ARG struct domain *d)
>>>       return xsm_default_action(action, current->domain, d);
>>>   }
>>>
>>> +static XSM_INLINE int xsm_memory_soft_reset(XSM_DEFAULT_ARG struct domain 
> *d1,
>>> +                                       struct domain *d2)
>>> +{
>>> +    XSM_ASSERT_ACTION(XSM_PRIV);
>>> +    return xsm_default_action(action, current->domain, NULL);
>>> +}
>>
>> Why XSM_PRIV instead of XSM_TARGET against _both_ domains?
> 
> Unless there is a change in how XSM_TARGET is implemented, the result
> is going to be equivalent: it is not possible for a domain to have
> more than one target at a time, so if current->domain is not dom0,
> then one of the two XSM_TARGET checks will fail.

Ah, right. But the thing here wants that expressed. But I guess this
should be a separate change later on. Vitaly - please leave a
respective comment around.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel