Re: [Xen-devel] [osstest test] 56922: regressions - FAIL

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sat, 2015-05-23 at 15:52 +0800, Robert Hu wrote:
> On Sat, 2015-05-23 at 07:58 +0100, Ian Campbell wrote:
> > On Sat, 2015-05-23 at 14:46 +0800, Robert Hu wrote:
> > > On Sat, 2015-05-23 at 11:35 +0800, Robert Hu wrote:
> > > > On Fri, 2015-05-22 at 15:21 +0100, Ian Campbell wrote:
> > > > > On Fri, 2015-05-22 at 14:42 +0100, Ian Campbell wrote:
> > > > > > From my particular grub.cfg. For real usage setupboot_grub2 will
> > > > > > obviously need to become cleverer to count things correctly.
> > > > > 
> > > > > I've not tested extensively but the following incremental patch seems 
> > > > > to
> > > > > do the right thing, at least by inspection of the resulting grub.cfg.
> > > > > 
> > > > > Needs more testing (e.g. I haven't tried non-XSM yet) and review from
> > > > > Ian I think, since there may be a more idiomatically Perl way to
> > > > > manipulate the @offsets array (in particular shrinking it).
> > > > Thanks Ian. You are so quick. I wrote that piece of code almost a year
> > > > ago; was just about to warm up. 
> > > > We're to test your fix in our environment as well on non-XSM.
> > > 
> > > Just furbished up that piece of code. Now I recall the memory. This
> > > piece of code was developed before 'XSM' things introduced; though now
> > > after XSM things merged. May I know what is 'xsm' stuff?
> > 
> > XSM is Xen Security Modules (sort of selinux for Xen). It involves some
> > special additional entries in grub to provide the policy.
> > 
> > > Can you send me the 'grub.cfg' of those 'xsm' cases? so that I can take
> > > a look.
> > 
> > All of the logs for the flight can be found at:
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/56922/
> > 
> > Clicking the heading of one of the failing tests would take you to e.g.:
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/56922/test-amd64-amd64-xl-xsm/info.html
> From the log I see 
> 'boot check: grub2, found Debian GNU/Linux, with Xen 4.6-unstable (XSM
> enabled) and Linux 3.14.43+'
> Seems it finds what ought to be.

Yes, but the corresponding thing which it puts into GRUB_DEFAULT (which
becomes "default" in grub.cfg) is "21" which is not correct, it needs to
be something like "8>1" to correctly refer to that entry.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel