Re: [Xen-devel] [osstest test] 56922: regressions - FAIL

[Robert Hu <robert.hu@xxxxxxxxxxxxxxxx>]

On Sun, 2015-05-24 at 14:53 +0100, Ian Campbell wrote:
> On Sat, 2015-05-23 at 16:53 +0800, Robert Hu wrote:
> > > > +                    $#offsets = $#offsets-1;
> > > > +                    $offsets[$#offsets]++;
> > may consider 'pop/push' operations on @offsets array? I worry about if
> > '$#offsets-1' can always shrink array size correctly. pop/push anyway is
> > some official way to do this.
> 
> Assigning to $#offsets is defined to change the length of the array. But
> I think you are correct that pop/push would be a more idiomatic way to
> do this.
> 
> It is a public holiday on Monday, but I'll take a look on Tuesday,
> unless you fancy doing it in the meantime.
Sure I will do this.
> 
> >  @@ -446,11 +446,12 @@ sub setupboot_grub2 ($$$$) {
> > > >              }
> > > >              if (m/^menuentry\s+[\'\"](.*)[\'\"].*\{\s*$/) {
> > > >                  die $entry->{StartLine} if $entry;
> > > > -                $entry= { Title => $1, StartLine => $., Number => 
> > > > $count };
> > > > -                $count++;
> > > > +                $entry= { Title => $1, StartLine => $., MenuEntryPath 
> > > > => join ">", @offsets };
> > > > +                $offsets[$#offsets]++;
> > > >              }
> > > >              if (m/^submenu\s+[\'\"](.*)[\'\"].*\{\s*$/) {
> > > > -                $submenu={ StartLine =>$.};
> > > > +                $submenu={ StartLine =>$., MenuEntryPath => join ">", 
> > > > @offsets };
> > Here MenuEntryPath element for $submenu is actually debug purpose only,
> > I think, may be can remove it. correct me if I'm wrong.
> 
> It is just for debug, I think it would be OK to leave it though.
> 
> Ian.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel