Re: [Xen-devel] [RFC v2 00/15] Add VT-d Posted-Interrupts support

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Tian, Kevin
> Sent: Monday, May 18, 2015 1:33 PM
> To: Wu, Feng; xen-devel@xxxxxxxxxxxxx
> Cc: keir@xxxxxxx; jbeulich@xxxxxxxx; andrew.cooper3@xxxxxxxxxx; Zhang,
> Yang Z; george.dunlap@xxxxxxxxxxxxx
> Subject: RE: [RFC v2 00/15] Add VT-d Posted-Interrupts support
> 
> > From: Wu, Feng
> > Sent: Friday, May 08, 2015 5:07 PM
> >
> > VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt.
> > With VT-d Posted-Interrupts enabled, external interrupts from
> > direct-assigned devices can be delivered to guests without VMM
> > intervention when guest is running in non-root mode.
> >
> > You can find the VT-d Posted-Interrtups Spec. in the following URL:
> >
> http://www.intel.com/content/www/us/en/intelligent-systems/intel-technolog
> > y/vt-directed-io-spec.html
> >
> > This patch set follow the following design:
> > http://article.gmane.org/gmane.comp.emulators.xen.devel/236476
> >
> > v1 -> v2
> > 1. Add the design doc.
> > 2. Coding style fix.
> > 3. Add some comments for struct pi_desc.
> > 4. Extend 'struct iremap_entry' to a more common format.
> > 5. Delete the atomic helper functions for pi descriptor manipulation.
> > 6. Add the new command line in docs/misc/xen-command-line.markdown.
> > 7. Use macros to replace some magic numbers.
> 
> Though generally this version looks good to me, it'd be clearer if you could
> give v1->v2 information per patch to help review. :-)

Good suggestion, Kevin! And here it is:

[RFC v2 01/15] Vt-d Posted-intterrupt (PI) design 
Add the design doc.

[RFC v2 04/15] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts 
Add some comments for struct pi_desc.

[RFC v2 05/15] vmx: Initialize VT-d Posted-Interrupts Descriptor
1. if ( iommu_intpost == 1 ) --> if ( iommu_intpost )
2. Don't need to clear SN and NDM fileds in pi_desc_init(), since it was clear 
to zero when initialized
3. Use macro "MASK_INSR" for "(dest << 8) & 0xFF00" in pi_desc_init()

[RFC v2 06/15] vt-d: Extend struct iremap_entry to support VT-d 
Posted-Interrupts
Extend 'struct iremap_entry' to a more common format.
1. Hide bit manipulation of IRTE inside a static inline function.
2. Define a new macro "PDA_MASK" to manipulate IRTE
3. Make the error message more informative.

[RFC v2 08/15] Update IRTE according to guest interrupt config changes
1. Check the result when dest_vcpu_array is allocated.
2. Use interrupt remapping when we encounter failures during interrupts 
setup/update for PI.

[RFC v2 10/15] vmx: Define two per-cpu variables
1. block_vcpu_on_cpu --> blocked_vcpu.
2. blocked_vcpu_lock _on_cpu --> blocked_vcpu_lock.

[RFC v2 11/15] vmx: Add a global wake-up vector for VT-d Posted-Interrupts
Adjust the initialization of "vmx_function_table.pi_desc_update"

[RFC v2 12/15] vmx: Properly handle notification event when vCPU is running
Add detailed description about the scenario in which the changes in this patch 
is used.

[RFC v2 13/15] Update Posted-Interrupts Descriptor during vCPU scheduling
Properly remove the vcpu from the blocked list when 'ON' field is set during 
vCPU is being blocked.

[RFC v2 15/15] Add a command line parameter for VT-d posted-interrupts
Add the new command line in docs/misc/xen-command-line.markdown.

Thanks,
Feng

> 
> Thanks
> Kevin


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel