Re: [Xen-devel] [xen-unstable test] 56456: regressions - FAIL

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.05.15 at 12:17, <tim@xxxxxxx> wrote:
> At 09:34 +0100 on 18 May (1431941676), Jan Beulich wrote:
>> >>> On 16.05.15 at 13:45, <roger.pau@xxxxxxxxxx> wrote:
>> > El 16/05/15 a les 10.51, osstest service user ha escrit:
>> >> flight 56456 xen-unstable real [real]
>> >> http://logs.test-lab.xenproject.org/osstest/logs/56456/ 
>> >>
>> >> Regressions :-(
>> >
>> > This is my fault, paging_gva_to_gfn cannot be used to translate a PV
>> > guest VA to a GFN. The patch above restores the previous path for PV
>> > callers.
>> 
>> While Tim would have the final say, I certainly would prefer to revert
>> the offending patch and then apply a correct new version in its stead
>> in this case (where the fix is not a simple, few lines change).
> 
> I would be OK with a follow-up fix here, but I'm not convinced that
> this is it.
> 
> In particular, paging_mode_enabled() should be true for any PV domain
> that's in log-dirty mode, so presumably the failure is only for lgd
> ops on VMs that don't have lgd enabled.  So maybe we can either:
>  - return an error for that case (but we'd want to understand how we
>    got there first); or
>  - have map_dirty_bitmap() DTRT, with something like access_ok() +
>    a linear-pagetable lookup to find the frame.
> 
> In any case, this is a regression so we should revert while we figure
> it out.

Done.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel