Re: [Xen-devel] [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

[Kevin Wolf <kwolf@xxxxxxxxxx>]

Am 14.05.2015 um 19:54 hat John Snow geschrieben:
> On 05/14/2015 10:07 AM, Michael S. Tsirkin wrote:
> > On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote:
> >> * Create the FDC only if the option is "on".
> >>
> >> * Optional: make -drive if=floppy,... auto-enable it
> > 
> > Every time we do such auto hacks, we regret this later.
> > Just do what we are told, fail if=floppy if disabled.
> > 
> 
> I agree very much. Just because the current drive/device syntax is
> almost totally hosed doesn't mean we should put more wood on the fire.

This is silly. Don't break our user interfaces just because you're
panicking and everybody is scared of floppies now.

The very purpose of if=foo (except if=none) is to add 'foo' hardware.
if=virtio adds a virtio-blk controller. if=scsi adds a SCSI controller
if no slot is available on an existing controller. Of course, if=floppy
must create all the hardware that is necessary to have a floppy drive.

If we ever add a -blockdev, it wouldn't have if=... at all, but for
-drive, if=... is part of the interface (and as a convenience feature, I
would always want to have options like this), so we shouldn't break it,
but keep it consistent.

> Maybe the best option here really is to carefully separate optional from
> non-optional components (FDC vs. Floppy Drive, Floppy Disk code) and
> just give the core FDC code a good scrubbing.

That would be nice if someone could finally find the time to do so.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel