[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 03/41] arm/acpi : emulate io ports for arm

To: Parth Dixit <parth.dixit@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxx>
From: Julien Grall <julien.grall@xxxxxxxxxx>
Date: Mon, 18 May 2015 14:03:44 +0100
Cc: keir@xxxxxxx, ian.campbell@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, tim@xxxxxxx, julien.grall@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxx, jbeulich@xxxxxxxx, christoffer.dall@xxxxxxxxxx
Delivery-date: Mon, 18 May 2015 13:04:27 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Hi Parth,

On 17/05/15 21:03, Parth Dixit wrote:
> add macros to emulate x86 style ports for arm.
> This avoids modification in common code for acpi.

This patch looks wrong to me. On ARM ioport access is done using the PCI
address space.

If it's not easy to have a correct implementation, I still prefer
modification in common ACPI code.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH v2 00/41] Add ACPI support for arm64 on Xen
  - From: Parth Dixit
- [Xen-devel] [PATCH v2 03/41] arm/acpi : emulate io ports for arm
  - From: Parth Dixit

Prev by Date: Re: [Xen-devel] [PATCH] tools: Fix wild memory allocations from c/s 250f0b4 and 85d78b4
Next by Date: Re: [Xen-devel] [PATCH v4] OSSTEST: introduce a raisin build test
Previous by thread: [Xen-devel] [PATCH v2 03/41] arm/acpi : emulate io ports for arm
Next by thread: [Xen-devel] [PATCH v2 05/41] acpi : add helper function for mapping memory
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.