Re: [Xen-devel] [PATCH v2 for Xen 4.6 1/4] xen: enabling XL to set per-VCPU parameters of a domain for RTDS scheduler

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.05.15 at 07:33, <lichong659@xxxxxxxxx> wrote:
> On Tue, May 26, 2015 at 12:18 PM, Chong Li <lichong659@xxxxxxxxx> wrote:
>> On Tue, May 26, 2015 at 4:08 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>>> On 26.05.15 at 02:05, <lichong659@xxxxxxxxx> wrote:
>>>> +/* Adjust scheduling parameter for the vcpus of a given domain. */
>>>> +long sched_adjust_vcpu(
>>>> +    struct domain *d,
>>>> +    struct xen_domctl_scheduler_vcpu_op *op)
>>>> +{
>>>> +    long ret;
>>>
>>> I see no reason for this and the function return type to be "long".
>>
>> The reason is stated in the begining.
> 
> Sorry for missing some details in the last reply.
> 
> sched_adjust_vcpu is added here because I need a seperate function to
> handle XEN_DOMCTL_scheduler_vcpu_op, which is a new hypercall
> dedicated for per-vcpu get/set. This function is actually based on
> sched_adjust (which is dedicated for per-dom get/set in rtds), so the
> return type is also the same.

You explain why you need the function, but I asked about why the
function return type and the quoted variable's types are "long".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel