[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V7] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event

>>> On 28.05.15 at 07:33, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> Changes since V6:
>  - Removed "Reviewed-by: Tim Deegan <tim@xxxxxxx>", as the patch
>    went beyond cosmetic-only changes.
>  - Parenthesized hvm_event_cr in event.c, to prevent expansion of
>    the macro with the same name if event.h gets #included.

I'm sorry, but I specifically said that you need to include the header
declaring the function (and macro) in the file defining it, but ...

> --- a/xen/arch/x86/hvm/event.c
> +++ b/xen/arch/x86/hvm/event.c
> @@ -21,6 +21,7 @@
>  #include <xen/vm_event.h>
>  #include <xen/paging.h>
> +#include <asm/monitor.h>
>  #include <public/vm_event.h>
>  static void hvm_event_fill_regs(vm_event_request_t *req)

... you didn't (and you also didn't in a prereq patch, which would have
been the alternative).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.