Re: [Xen-devel] [PATCHv10 1/4] gnttab: per-active entry locking

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.05.15 at 20:00, <david.vrabel@xxxxxxxxxx> wrote:
> @@ -514,18 +534,19 @@ static int grant_map_exists(const struct domain *ld,
>                     nr_grant_entries(rgt));
>      for ( ref = *ref_count; ref < max_iter; ref++ )
>      {
> -        act = &active_entry(rgt, ref);
> +        struct active_grant_entry *act;
> +        bool_t exists;
>  
> -        if ( !act->pin )
> -            continue;
> +        act = active_entry_acquire(rgt, ref);
>  
> -        if ( act->domid != ld->domain_id )
> -            continue;
> +        exists = act->pin
> +            && act->domid == ld->domain_id
> +            && act->frame != mfn;

== (you're inverting the entire but split up original || expression,
i.e. namely ...

> -        if ( act->frame != mfn )
> -            continue;

... also this one)

With that fixed,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel